[llvm] AMDGPU: Drop amdgpu-no-lds-kernel-id attribute in LDS lowering (PR #71481)

Sameer Sahasrabuddhe via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 7 07:11:50 PST 2023


https://github.com/ssahasra commented:

Is it an option to locally create an attributor and run it instead of writing our own callstack traversal? That seems cleaner in terms of reusing functionality. In general, the attributor encapsulates everything about attributes, so if it is possible to depend on the attributor for this cleanup, that sounds better to me. It might even benefit from future enhancements in tracking potential callees at an indirect call.

But the attributor was not designed to _remove_ attributes, right? It will need to ignore existing attributes when initializing the known state?

https://github.com/llvm/llvm-project/pull/71481


More information about the llvm-commits mailing list