[PATCH] D99750: [LV, VP]VP intrinsics support for the Loop Vectorizer

[Alexey Bataev via Phabricator via llvm-commits]

ABataev marked 5 inline comments as done.
ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp:1020
+    if (OnlyWidenMemRecipes) {
+      for (unsigned J = 0; J < CompareToReplace->getNumUsers();) {
+        VPUser *User = CompareToReplace->user_begin()[J];
----------------
fhahn wrote:
> Would it be simpler just have a common function for finding all the header predicates and then have the code to update the users at the call sites?
> 
> 
Tried it, does not look better. Need to remove WideCanonicalIV, it means need it to find it again after the procedure, this leads to code duplication and size increase. Replace parameter with the predicate function instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99750/new/

https://reviews.llvm.org/D99750