[llvm] [InstCombine] Fold converted urem to 0 if there's no overlapping bits (PR #71528)
Yingwei Zheng via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 7 05:14:54 PST 2023
================
@@ -0,0 +1,52 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2
+; RUN: opt -mtriple unknown -passes=instcombine -S < %s | FileCheck %s
+
+;; The and X, (add Y, -1) pattern is from an earlier instcombine pass which
+;; converted
+
+;; define dso_local i64 @f1() local_unnamed_addr #0 {
+;; entry:
+;; %0 = call i64 @llvm.aarch64.sve.cntb(i32 31)
+;; %1 = call i64 @llvm.aarch64.sve.cnth(i32 31)
+;; %rem = urem i64 %0, %1
+;; ret i64 %rem
+;; }
+
+;; into
+
+;; define dso_local i64 @f1() local_unnamed_addr #0 {
+;; entry:
+;; %0 = call i64 @llvm.vscale.i64()
+;; %1 = shl nuw nsw i64 %0, 4
+;; %2 = call i64 @llvm.vscale.i64()
+;; %3 = shl nuw nsw i64 %2, 3
+;; %4 = add nsw i64 %3, -1
+;; %rem = and i64 %1, %4
+;; ret i64 %rem
+;; }
+
+;; InstCombine would have folded the original to returning 0 if the vscale
+;; calls were the same Value*, but since there's two of them it doesn't
+;; work and we convert the urem to add/and. CSE then gets rid of the extra
+;; vscale, leaving us with a new pattern to match. This only works because
+;; vscale is known to be a nonzero power of 2 (assuming there's a defined
+;; range for it).
+
+define dso_local i64 @f1() local_unnamed_addr #0 {
----------------
dtcxzyw wrote:
Please drop unused attributes and flags.
https://github.com/llvm/llvm-project/pull/71528
More information about the llvm-commits
mailing list