[llvm] [RISCV][GlobalISel] Vector Extension vadd Legalizer (PR #71400)

Michael Maitland via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 6 08:51:48 PST 2023


michaelmaitland wrote:

Are you able to reorder your commits with `git rebase -i`? The commits that this PR is stacked on should come first, followed by the commits introduced by this PR. It may also be helpful to reword your commits using the `r` option once you are in `git rebase -i` so that it takes the name of the PR.

We should get the commit history to look like this:

```
[CodeGen][MachineVerifier] Use TypeSize instead of unsigned for getRegSizeInBits
[RISCV][GISEL] Add support for lowerFormalArguments that contain scalable vector types
[RISCV][GlobalISel] Vector Extension vadd Legalizer
```

Once it looks like this, you can force push to this branch. This will give reviewers an easy way to review the changes introduced in your commit. Then you can push additional commits to the branch as you respond to review comments. You can see an example of this here: https://github.com/llvm/llvm-project/pull/70882/commits.

https://github.com/llvm/llvm-project/pull/71400


More information about the llvm-commits mailing list