[PATCH] D158333: [VPlan] Move initial skeleton construction to createInitialVPlan. (NFC)

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 6 02:31:39 PST 2023


Ayal added a comment.

In D158333#4654836 <https://reviews.llvm.org/D158333#4654836>, @fhahn wrote:

> Address latest comments, thanks!
>
> In D158333#4654821 <https://reviews.llvm.org/D158333#4654821>, @Ayal wrote:
>
>> In summary: "This patch moves creating **the preheader and** middle VPBBs as well as the
>> initial empty vector loop region to createInitialVPlan" - only middle VPBB and region are moved, preheader is already there.
>
> Adjusted, thanks!

There are still some pending comments, right? In particular regarding simplifying getOrCreateVPBB() wrt the exceptional header VPBB of TheLoop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158333/new/

https://reviews.llvm.org/D158333



More information about the llvm-commits mailing list