[PATCH] D138847: MC/DC in LLVM Source-Based Code Coverage: llvm-cov visualization

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-cov/mcdc-const.test:72
+// CHECKFULLCASE: |  C1-Pair: constant folded
+// CHECKFULLCASE: |  C2-Pair: covered: (1,2)
+// CHECKFULLCASE: |  MC/DC Coverage for Decision: 100.00%
----------------
Prefer `-NEXT` for adjacent lines


================
Comment at: llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp:973
+    const CounterMappingRegion &DecisionRegion = Record.getDecisionRegion();
+    std::string LineNoStr = utostr(uint64_t(DecisionRegion.LineStart));
+    std::string ColNoStr = utostr(uint64_t(DecisionRegion.ColumnStart));
----------------
Use `Twine` https://llvm.org/docs/ProgrammersManual.html#the-twine-class


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138847/new/

https://reviews.llvm.org/D138847