[llvm] [BOLT][AArch64] Don't change layout in PatchEntries (PR #71278)
Vladislav Khmelevsky via llvm-commits
llvm-commits at lists.llvm.org
Sun Nov 5 01:15:13 PDT 2023
================
@@ -98,6 +98,17 @@ void PatchEntries::runOnFunctions(BinaryContext &BC) {
});
if (!Success) {
+ // We can't change output layout for AArch64 due to LongJmp pass
----------------
yota9 wrote:
I would say yes. Internally we're using rewrite option so old text is completely removed, so we expect everything to be disassembled properly. To be honest I didn't even know that patch entries is forced to run. Also patch entries skips functions which size is smaller than 128 anyway, that we might consider not safe too, but we're doing it :) And finally the chance to call old function on ARM is smaller due to +- 128 mb limit.
https://github.com/llvm/llvm-project/pull/71278
More information about the llvm-commits
mailing list