[compiler-rt] [sanitizer] Fix pthread_exit interceptor's return type (PR #71253)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 3 16:43:11 PDT 2023
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-compiler-rt-sanitizer
Author: Heejin Ahn (aheejin)
<details>
<summary>Changes</summary>
`pthread_exit`'s return type is void.
---
Full diff: https://github.com/llvm/llvm-project/pull/71253.diff
3 Files Affected:
- (modified) compiler-rt/lib/asan/asan_interceptors.cpp (+2-2)
- (modified) compiler-rt/lib/hwasan/hwasan_interceptors.cpp (+2-2)
- (modified) compiler-rt/lib/lsan/lsan_interceptors.cpp (+2-2)
``````````diff
diff --git a/compiler-rt/lib/asan/asan_interceptors.cpp b/compiler-rt/lib/asan/asan_interceptors.cpp
index 876682c3b6b3a35..0ee8e0ea786edeb 100644
--- a/compiler-rt/lib/asan/asan_interceptors.cpp
+++ b/compiler-rt/lib/asan/asan_interceptors.cpp
@@ -300,9 +300,9 @@ INTERCEPTOR(int, pthread_detach, void *thread) {
return result;
}
-INTERCEPTOR(int, pthread_exit, void *retval) {
+INTERCEPTOR(void, pthread_exit, void *retval) {
asanThreadArgRetval().Finish(GetThreadSelf(), retval);
- return REAL(pthread_exit)(retval);
+ REAL(pthread_exit)(retval);
}
# if ASAN_INTERCEPT_TRYJOIN
diff --git a/compiler-rt/lib/hwasan/hwasan_interceptors.cpp b/compiler-rt/lib/hwasan/hwasan_interceptors.cpp
index 0889831373a8039..d7405b06752f421 100644
--- a/compiler-rt/lib/hwasan/hwasan_interceptors.cpp
+++ b/compiler-rt/lib/hwasan/hwasan_interceptors.cpp
@@ -322,9 +322,9 @@ INTERCEPTOR(int, pthread_detach, void *thread) {
return result;
}
-INTERCEPTOR(int, pthread_exit, void *retval) {
+INTERCEPTOR(void, pthread_exit, void *retval) {
hwasanThreadArgRetval().Finish(GetThreadSelf(), retval);
- return REAL(pthread_exit)(retval);
+ REAL(pthread_exit)(retval);
}
# if SANITIZER_GLIBC
diff --git a/compiler-rt/lib/lsan/lsan_interceptors.cpp b/compiler-rt/lib/lsan/lsan_interceptors.cpp
index fac6133ddf21b26..885f7ad5ddba961 100644
--- a/compiler-rt/lib/lsan/lsan_interceptors.cpp
+++ b/compiler-rt/lib/lsan/lsan_interceptors.cpp
@@ -490,9 +490,9 @@ INTERCEPTOR(int, pthread_detach, void *thread) {
return result;
}
-INTERCEPTOR(int, pthread_exit, void *retval) {
+INTERCEPTOR(void, pthread_exit, void *retval) {
GetThreadArgRetval().Finish(GetThreadSelf(), retval);
- return REAL(pthread_exit)(retval);
+ REAL(pthread_exit)(retval);
}
# if SANITIZER_INTERCEPT_TRYJOIN
``````````
</details>
https://github.com/llvm/llvm-project/pull/71253
More information about the llvm-commits
mailing list