[lld] [LLD] [COFF] Handle manually defined __imp_ pointers in LTO (PR #70777)

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 3 15:29:59 PDT 2023


================
@@ -1061,6 +1061,11 @@ void BitcodeFile::parse() {
     } else {
       sym = ctx.symtab.addRegular(this, symName, nullptr, fakeSC, 0,
                                   objSym.isWeak());
+      // If one LTO object defines a __imp_<foo> symbol, and another LTO
----------------
rnk wrote:

The use case you've described is very specific, can you please lead with a higher-level comment about what this code does? As a suggestion, you can start with:
// Model all symbols with the `__imp_` prefix as having external references. If one LTO object ...

https://github.com/llvm/llvm-project/pull/70777


More information about the llvm-commits mailing list