[llvm] b863fcb - [OptBisect] Remove an unused method declaration. NFC (#71145)

via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 3 10:40:21 PDT 2023


Author: Igor Kudrin
Date: 2023-11-04T00:40:16+07:00
New Revision: b863fcb6d4514ca61f7cfe5f6750b8ce06659eae

URL: https://github.com/llvm/llvm-project/commit/b863fcb6d4514ca61f7cfe5f6750b8ce06659eae
DIFF: https://github.com/llvm/llvm-project/commit/b863fcb6d4514ca61f7cfe5f6750b8ce06659eae.diff

LOG: [OptBisect] Remove an unused method declaration. NFC (#71145)

The body of `OptBisect::checkPass()` was moved to
`OptBisect::shouldRunPass()` in
[D137149](https://reviews.llvm.org/D137149).

Added: 
    

Modified: 
    llvm/include/llvm/IR/OptBisect.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/IR/OptBisect.h b/llvm/include/llvm/IR/OptBisect.h
index 2987e5ad90c4d3c..507d415d5e112bb 100644
--- a/llvm/include/llvm/IR/OptBisect.h
+++ b/llvm/include/llvm/IR/OptBisect.h
@@ -53,7 +53,14 @@ class OptBisect : public OptPassGate {
 
   /// Checks the bisect limit to determine if the specified pass should run.
   ///
-  /// This forwards to checkPass().
+  /// The method prints the name of the pass, its assigned bisect number, and
+  /// whether or not the pass will be executed. It returns true if the pass
+  /// should run, i.e. if the bisect limit is set to -1 or has not yet been
+  /// exceeded.
+  ///
+  /// Most passes should not call this routine directly. Instead, it is called
+  /// through helper routines provided by the base classes of the pass. For
+  /// instance, function passes should call FunctionPass::skipFunction().
   bool shouldRunPass(const StringRef PassName,
                      StringRef IRDescription) override;
 
@@ -67,19 +74,6 @@ class OptBisect : public OptPassGate {
     LastBisectNum = 0;
   }
 
-  /// Checks the bisect limit to determine if the specified pass should run.
-  ///
-  /// If the bisect limit is set to -1, the function prints a message describing
-  /// the pass and the bisect number assigned to it and return true.  Otherwise,
-  /// the function prints a message with the bisect number assigned to the
-  /// pass and indicating whether or not the pass will be run and return true if
-  /// the bisect limit has not yet been exceeded or false if it has.
-  ///
-  /// Most passes should not call this routine directly. Instead, they are
-  /// called through helper routines provided by the pass base classes.  For
-  /// instance, function passes should call FunctionPass::skipFunction().
-  bool checkPass(const StringRef PassName, const StringRef TargetDesc);
-
   static const int Disabled = std::numeric_limits<int>::max();
 
 private:


        


More information about the llvm-commits mailing list