[llvm] [InstrProf] Do not block functions from PGOUse (PR #71106)

Mircea Trofin via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 3 07:37:44 PDT 2023


================
@@ -1760,17 +1760,10 @@ static void collectComdatMembers(
       ComdatMembers.insert(std::make_pair(C, &GA));
 }
 
-// Don't perform PGO instrumeatnion / profile-use.
-static bool skipPGO(const Function &F) {
+// Return true if we should not annotate this function for PGO
----------------
mtrofin wrote:

Nit: how about `Return true if we should not attempt to find an instrumented profile for this function`? (because "annotate" is ambiguous - there are other annotations, I guess you mean profile metadata here? Then, "PGO" really means "instrumented profile use" here)

https://github.com/llvm/llvm-project/pull/71106


More information about the llvm-commits mailing list