[llvm] 33a6014 - Revert D87067 "[llvm-symbolizer] Add back --use-symbol-table=true"

[Fangrui Song via llvm-commits]

Author: Fangrui Song
Date: 2023-11-03T00:09:11-07:00
New Revision: 33a60141b3101bb31dabdabe22750b5003506867

URL: https://github.com/llvm/llvm-project/commit/33a60141b3101bb31dabdabe22750b5003506867
DIFF: https://github.com/llvm/llvm-project/commit/33a60141b3101bb31dabdabe22750b5003506867.diff

LOG: Revert D87067 "[llvm-symbolizer] Add back --use-symbol-table=true"

This reverts commit 3d54976a704327aea8de85f7b2c36172e42100d9.

This was added as a temporary courtesy to a misuse
https://android-review.googlesource.com/c/platform/ndk/+/1419436 (2020).

Added: 
    

Modified: 
    llvm/tools/llvm-symbolizer/Opts.td

Removed: 
    llvm/test/tools/llvm-symbolizer/use-symbol-table.s


################################################################################
diff  --git a/llvm/test/tools/llvm-symbolizer/use-symbol-table.s b/llvm/test/tools/llvm-symbolizer/use-symbol-table.s
deleted file mode 100644
index aed7d43d339166f..000000000000000
--- a/llvm/test/tools/llvm-symbolizer/use-symbol-table.s
+++ /dev/null
@@ -1,7 +0,0 @@
-# REQUIRES: x86-registered-target
-
-# RUN: llvm-mc -filetype=obj -triple=x86_64 -g %s -o %t.o
-
-## --use-symbol-table=true is used by old asan_symbolize.py and Android ndk
-## ndk-stack.py. Keep it as a no-op compatibility option for a while.
-# RUN: llvm-symbolizer --use-symbol-table=true %t.o

diff  --git a/llvm/tools/llvm-symbolizer/Opts.td b/llvm/tools/llvm-symbolizer/Opts.td
index 6742e086d6ff954..edc80bfe59673ba 100644
--- a/llvm/tools/llvm-symbolizer/Opts.td
+++ b/llvm/tools/llvm-symbolizer/Opts.td
@@ -82,5 +82,3 @@ def : Flag<["--"], "inlining=false">, Alias<no_inlines>, HelpText<"Alias for --n
 // Compatibility aliases for pprof's symbolizer.
 def : Flag<["-"], "demangle=true">, Alias<demangle>, HelpText<"Alias for --demangle">;
 def : Flag<["-"], "demangle=false">, Alias<no_demangle>, HelpText<"Alias for --no-demangle">;
-// Compatibility no-op options.
-def : Flag<["--"], "use-symbol-table=true">;