[llvm] [llvm-symbolizer] restore --[no-]use-symbol-table option (PR #71008)

via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 3 00:04:03 PDT 2023


quic-likaid wrote:

> > no-op: [reviews.llvm.org/D87067](https://reviews.llvm.org/D87067)
> 
> https://android-review.googlesource.com/c/platform/ndk/+/1419436 landed 3 years ago. I think we can remove `--use-symbol-table=true` now.

I can remove it if nobody objects

> Do you have an example how a false `UseSymbolTable` behaves differently?

I just added a test to the commit. It prints `b` when use symbol table, and `foo` if not.

The test is somewhat artifitial though, here is an output from real world .ko, which motivated this PR (the module is too large to be shared here):

```
$ llvm-addr2line -afie qca_cld3_kiwi_v2.ko 0x3482c4
0x3482c4
__lim_process_sme_set_ht2040_mode
out/android14-6.1/msm-kernel/../vendor/qcom/opensource/wlan/qcacld-3.0/core/mac/src/pe/lim/lim_process_sme_req_messages.c:7981
global_dfs
out/android14-6.1/msm-kernel/../vendor/qcom/opensource/wlan/qcacld-3.0/core/mac/src/pe/lim/lim_process_sme_req_messages.c:9013

$ llvm-addr2line --no-use-symbol-table -afie qca_cld3_kiwi_v2.ko 0x3482c4
__lim_process_sme_set_ht2040_mode
out/android14-6.1/msm-kernel/../vendor/qcom/opensource/wlan/qcacld-3.0/core/mac/src/pe/lim/lim_process_sme_req_messages.c:7981
lim_process_sme_req_messages
out/android14-6.1/msm-kernel/../vendor/qcom/opensource/wlan/qcacld-3.0/core/mac/src/pe/lim/lim_process_sme_req_messages.c:9013
```


https://github.com/llvm/llvm-project/pull/71008


More information about the llvm-commits mailing list