[llvm] ae49bf5 - [RISCV] Fix stale comments in lowerShift*Parts. NFC
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 2 22:20:59 PDT 2023
Author: Craig Topper
Date: 2023-11-02T22:20:49-07:00
New Revision: ae49bf5a7bab332fb3a1362d70b325208de7d0ff
URL: https://github.com/llvm/llvm-project/commit/ae49bf5a7bab332fb3a1362d70b325208de7d0ff
DIFF: https://github.com/llvm/llvm-project/commit/ae49bf5a7bab332fb3a1362d70b325208de7d0ff.diff
LOG: [RISCV] Fix stale comments in lowerShift*Parts. NFC
This comment was not updated when we changed from xor back to sub.
Added:
Modified:
llvm/lib/Target/RISCV/RISCVISelLowering.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
index ec5ae3e8f8d5419..3c7566e8c411ed1 100644
--- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
+++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -7159,7 +7159,7 @@ SDValue RISCVTargetLowering::lowerShiftLeftParts(SDValue Op,
// if Shamt-XLEN < 0: // Shamt < XLEN
// Lo = Lo << Shamt
- // Hi = (Hi << Shamt) | ((Lo >>u 1) >>u (XLEN-1 ^ Shamt))
+ // Hi = (Hi << Shamt) | ((Lo >>u 1) >>u (XLEN-1 - Shamt))
// else:
// Lo = 0
// Hi = Lo << (Shamt-XLEN)
@@ -7198,7 +7198,7 @@ SDValue RISCVTargetLowering::lowerShiftRightParts(SDValue Op, SelectionDAG &DAG,
// SRA expansion:
// if Shamt-XLEN < 0: // Shamt < XLEN
- // Lo = (Lo >>u Shamt) | ((Hi << 1) << (ShAmt ^ XLEN-1))
+ // Lo = (Lo >>u Shamt) | ((Hi << 1) << (XLEN-1 - ShAmt))
// Hi = Hi >>s Shamt
// else:
// Lo = Hi >>s (Shamt-XLEN);
@@ -7206,7 +7206,7 @@ SDValue RISCVTargetLowering::lowerShiftRightParts(SDValue Op, SelectionDAG &DAG,
//
// SRL expansion:
// if Shamt-XLEN < 0: // Shamt < XLEN
- // Lo = (Lo >>u Shamt) | ((Hi << 1) << (ShAmt ^ XLEN-1))
+ // Lo = (Lo >>u Shamt) | ((Hi << 1) << (XLEN-1 - ShAmt))
// Hi = Hi >>u Shamt
// else:
// Lo = Hi >>u (Shamt-XLEN);
More information about the llvm-commits
mailing list