[PATCH] D151730: [RISCV] Support target attribute for function

[Piyou Chen via Phabricator via llvm-commits]

BeMg added inline comments.


================
Comment at: clang/lib/Basic/Targets/RISCV.cpp:434
+        if (MarchFromCPU != "") {
+          Ret.Features.clear();
+          handleFullArchString(MarchFromCPU, Ret.Features);
----------------
craig.topper wrote:
> Why does this clear Ret.Features, but full-arch-string doesn't?
I think full-arch-string also clear the Ret.Features in line 398 right after `if (Feature.startswith("arch="))`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151730/new/

https://reviews.llvm.org/D151730