[llvm] llvm: [NFC] Robustify testcase (PR #71120)

Nathan Sidwell via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 2 15:12:43 PDT 2023


https://github.com/urnathan created https://github.com/llvm/llvm-project/pull/71120

This is llvm's instance of unfortunate testfailure with a pathname containing 'alias'. Clang's case was addressed with https://github.com/llvm/llvm-project/pull/69739.  CHECK-NOT regexes can be tricky.

Expect llvm-as diagnostic and robustify 'alias' check-not, to avoid problems with pathnames.

>From 97e4ddeea925fce00ef47102ab21114543c3be65 Mon Sep 17 00:00:00 2001
From: Nathan Sidwell <nathan at acm.org>
Date: Wed, 1 Nov 2023 16:08:38 -0400
Subject: [PATCH] llvm: [NFC] Robustify testcase

Expect llvm-as diagnostic and robustify 'alias' check-not, to avoid
problems with pathnames.
---
 llvm/test/Verifier/alias.ll | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/llvm/test/Verifier/alias.ll b/llvm/test/Verifier/alias.ll
index 8d755ec6a91c6f9..ec0e7d798fea41a 100644
--- a/llvm/test/Verifier/alias.ll
+++ b/llvm/test/Verifier/alias.ll
@@ -1,5 +1,7 @@
-; RUN:  not llvm-as %s -o /dev/null 2>&1 | FileCheck %s --implicit-check-not=alias --implicit-check-not=Alias
+; RUN:  not llvm-as %s -o /dev/null 2>&1 | FileCheck %s
 
+; CHECK: llvm-as: assembly parsed, but does not verify as correct!
+; CHECK-NOT: {{(^A| a)lias(es)? }}
 
 declare void @f()
 @fa = alias void (), ptr @f



More information about the llvm-commits mailing list