[PATCH] D154080: [DebugInfo][RemoveDIs] Add conversion utilities between dbg.value form and DPValue new-debug-info form

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 2 07:56:11 PDT 2023


jmorse added a subscriber: nikic.
jmorse added a comment.

I'm slightly surprised to see that this is regressing -g performance a bit [0], I'd thought I'd kept all these patches from actually being _used_ by LLVM until later ones land and switches are enabled. Two possibilities to my mind:

- It's the linear walk over the blocks instructions to clear DPMarkers at the end. That's something we can polish later, and #ifdef guard for now.
- Something in the metadata maps added in D153990 <https://reviews.llvm.org/D153990> is getting slower? If so that must be down to branching?

All of this is #ifdef guardable while we're getting this prototype in, I just need to work out what part is the cause. CC @nikic  to signal that we're doing something about this.

[0] http://llvm-compile-time-tracker.com/compare.php?from=c95253b1bac865b6d90cce186b7d665de163d50c&to=7d77bbef4ad9230f6f427649373fe46a668aa909&stat=instructions%3Au


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154080/new/

https://reviews.llvm.org/D154080



More information about the llvm-commits mailing list