[llvm] [LLVM][DWARF] Add support for monolithic types in .debug_names (PR #70515)

[David Blaikie via llvm-commits]

================
@@ -310,17 +344,19 @@ void emitAppleAccelTable(AsmPrinter *Asm, AccelTable<DataT> &Contents,
 
 void emitDWARF5AccelTable(AsmPrinter *Asm, DWARF5AccelTable &Contents,
                           const DwarfDebug &DD,
-                          ArrayRef<std::unique_ptr<DwarfCompileUnit>> CUs);
-
+                          ArrayRef<std::unique_ptr<DwarfCompileUnit>> CUs,
+                          TUVectorTy TUSymbols);
+using GetIndexForEntryReturnType =
----------------
dwblaikie wrote:

So the new name is `DWARF5AccelTableEntryReturnType` yeah? It still doesn't really describe what's in it - it's some "return type" which isn't helpful in terms of knowing what's in it, how we should use it, what it means.
So it's actually `using DWARF5AccelTableEntryReturnType = std::optional<DWARF5AccelTableEntry>;` - yeah, I don't think we should introduce that typedef - we should write out that type explicitly, because it's more legible as `std::optional<DWARF5AccelTableEntry>`

https://github.com/llvm/llvm-project/pull/70515