[llvm] [LLVM][DWARF] Add support for monolithic types in .debug_names (PR #70515)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 1 17:06:27 PDT 2023


================
@@ -306,9 +306,18 @@ void DwarfStreamer::emitDebugNames(DWARF5AccelTable &Table) {
   }
 
   Asm->OutStreamer->switchSection(MOFI->getDwarfDebugNamesSection());
+  dwarf::Form Form = DIEInteger::BestForm(/*IsSigned*/ false,
+                                          (uint64_t)UniqueIdToCuMap.size() - 1);
+  /// llvm-dwarfutil doesn't support type units + .debug_names right now anyway,
+  /// so just keeping current behavior.
----------------
dwblaikie wrote:

"keeping current behavior" describes the patch, rather than the static state of the code - so this comment seems like it might be confusing. Could this be a statement of the current state of the system instead? ("FIXME: add support for type units + .debug_names. For now the behavior is <blah>" (ignores/rejects/corrupts/etc))

https://github.com/llvm/llvm-project/pull/70515


More information about the llvm-commits mailing list