[PATCH] D154353: [DebugInfo][RemoveDIs] Implement behind-the-scenes debug-info maintenance in splice / moveBefore / insertBefore APIs

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

Unittests LGTM. Comprehensive coverage yet easy to read, nice.



================
Comment at: llvm/unittests/IR/BasicBlockDbgInfoTest.cpp:1090
+  ASSERT_FALSE(Entry.TrailingDPValues.StoredDPValues.empty());
+
+  // Now transfer the entire contents of the exit block into the entry.
----------------
`ASSERT/CHECK_TRUE(Entry.empty())` for completeness? YMMV on this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154353/new/

https://reviews.llvm.org/D154353