[llvm] [llvm][AArch64][Assembly]: Add LUT assembly/disassembly. (PR #70802)

via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 1 02:15:28 PDT 2023


================
@@ -4546,14 +4548,18 @@ ParseStatus AArch64AsmParser::tryParseZTOperand(OperandVector &Operands) {
     if (getParser().parseExpression(ImmVal))
       return ParseStatus::NoMatch;
     const MCConstantExpr *MCE = dyn_cast<MCConstantExpr>(ImmVal);
+    Operands.push_back(AArch64Operand::CreateImm(
----------------
CarolineConcatto wrote:

Can you change the order between the tests and the Operand push
```
   if (!MCE)
      return TokError("immediate value expected for vector index");
    Operands.push_back(AArch64Operand::CreateImm( ...);
```
It makes more sense because we are using MCE->getValue() when getting the value, if MCE does not exists it will fail

https://github.com/llvm/llvm-project/pull/70802


More information about the llvm-commits mailing list