[llvm] 604eff6 - [SelectionDAG] Update comments that refer to MVT::Glue as a 'flag'
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 31 16:58:58 PDT 2023
Author: Craig Topper
Date: 2023-10-31T16:47:38-07:00
New Revision: 604eff60abfce09f956c3b0b1414f8d0d04b5d47
URL: https://github.com/llvm/llvm-project/commit/604eff60abfce09f956c3b0b1414f8d0d04b5d47
DIFF: https://github.com/llvm/llvm-project/commit/604eff60abfce09f956c3b0b1414f8d0d04b5d47.diff
LOG: [SelectionDAG] Update comments that refer to MVT::Glue as a 'flag'
Added:
Modified:
llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
Removed:
################################################################################
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
index 82481c60d16c43b..4ef5fd87d1340c2 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -963,7 +963,7 @@ static void AddNodeIDNode(FoldingSetNodeID &ID, const SDNode *N) {
/// doNotCSE - Return true if CSE should not be performed for this node.
static bool doNotCSE(SDNode *N) {
if (N->getValueType(0) == MVT::Glue)
- return true; // Never CSE anything that produces a flag.
+ return true; // Never CSE anything that produces a glue result.
switch (N->getOpcode()) {
default: break;
@@ -975,7 +975,7 @@ static bool doNotCSE(SDNode *N) {
// Check that remaining values produced are not flags.
for (unsigned i = 1, e = N->getNumValues(); i != e; ++i)
if (N->getValueType(i) == MVT::Glue)
- return true; // Never CSE anything that produces a flag.
+ return true; // Never CSE anything that produces a glue result.
return false;
}
@@ -1209,7 +1209,7 @@ bool SelectionDAG::RemoveNodeFromCSEMaps(SDNode *N) {
}
#ifndef NDEBUG
// Verify that the node was actually in one of the CSE maps, unless it has a
- // flag result (which cannot be CSE'd) or is one of the special cases that are
+ // glue result (which cannot be CSE'd) or is one of the special cases that are
// not subject to CSE.
if (!Erased && N->getValueType(N->getNumValues()-1) != MVT::Glue &&
!N->isMachineOpcode() && !doNotCSE(N)) {
@@ -5886,7 +5886,7 @@ SDValue SelectionDAG::getNode(unsigned Opcode, const SDLoc &DL, EVT VT,
SDNode *N;
SDVTList VTs = getVTList(VT);
SDValue Ops[] = {N1};
- if (VT != MVT::Glue) { // Don't CSE flag producing nodes
+ if (VT != MVT::Glue) { // Don't CSE glue producing nodes
FoldingSetNodeID ID;
AddNodeIDNode(ID, Opcode, VTs, Ops);
void *IP = nullptr;
@@ -7217,7 +7217,7 @@ SDValue SelectionDAG::getNode(unsigned Opcode, const SDLoc &DL, EVT VT,
break;
}
- // Memoize node if it doesn't produce a flag.
+ // Memoize node if it doesn't produce a glue result.
SDNode *N;
SDVTList VTs = getVTList(VT);
SDValue Ops[] = {N1, N2, N3};
@@ -8356,7 +8356,7 @@ SDValue SelectionDAG::getMemIntrinsicNode(unsigned Opcode, const SDLoc &dl,
(int)Opcode >= ISD::FIRST_TARGET_MEMORY_OPCODE)) &&
"Opcode is not a memory-accessing opcode!");
- // Memoize the node unless it returns a flag.
+ // Memoize the node unless it returns a glue result.
MemIntrinsicSDNode *N;
if (VTList.VTs[VTList.NumVTs-1] != MVT::Glue) {
FoldingSetNodeID ID;
@@ -9999,7 +9999,7 @@ SDValue SelectionDAG::getNode(unsigned Opcode, const SDLoc &DL, SDVTList VTList,
#endif
}
- // Memoize the node unless it returns a flag.
+ // Memoize the node unless it returns a glue result.
SDNode *N;
if (VTList.VTs[VTList.NumVTs-1] != MVT::Glue) {
FoldingSetNodeID ID;
More information about the llvm-commits
mailing list