[llvm] Verifier: forbid non-i32/i64 lrint, and non-i64 llrint (PR #70839)

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 31 12:05:22 PDT 2023


topperc wrote:

> Moreover, as evident from the patch, there is no test coverage for non-i32/i64 llvm.lrint and non-i64 llvm.llrint in test/CodeGen for any target. If future contributors want to support these things, they can remove the Verifier check, and add test coverage along with their patch. As it currently stands, I'm convinced that we don't support these configurations in practice, even if the LangRef isn't explicit about this.

There's sort of an implicit contract that the scalar intrinsics would only be created by calls to the functions in C code so the types match the C type for long or long long which LLVM itself doesn't know about.

https://github.com/llvm/llvm-project/pull/70839


More information about the llvm-commits mailing list