[llvm] [LLVM][DWARF] Add support for monolithic types in .debug_names (PR #70515)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 31 11:50:03 PDT 2023


================
@@ -1777,6 +1779,10 @@ void DwarfUnit::emitCommonHeader(bool UseOffsets, dwarf::UnitType UT) {
 }
 
 void DwarfTypeUnit::emitHeader(bool UseOffsets) {
+  if (!DD->useSplitDwarf()) {
+    LabelBegin = Asm->createTempSymbol("tu_begin");
+    Asm->OutStreamer->emitLabel(LabelBegin);
+  }
----------------
dwblaikie wrote:

Fair enough - there's not harm in putting local symbols in dwo sections, since they won't be emitted into dwo files anyway - but yeah, no reason to.

Knowing what the assert was might be interesting. (perhaps we do make the simplifying assumption and assert that there aren't labels in dwo sections, but I don't think so... - I think we do assert that there aren't any /relocations/ in dwo files)

https://github.com/llvm/llvm-project/pull/70515


More information about the llvm-commits mailing list