[llvm] [LoopPeeling] Fix weights updating of peeled off branches (PR #70094)

Aleksandr Popov via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 31 04:27:30 PDT 2023


================
@@ -636,9 +636,13 @@ static void updateBranchWeights(Instruction *Term, WeightInfo &Info) {
                     MDB.createBranchWeights(Info.Weights));
   for (auto [Idx, SubWeight] : enumerate(Info.SubWeights))
     if (SubWeight != 0)
-      Info.Weights[Idx] = Info.Weights[Idx] > SubWeight
-                              ? Info.Weights[Idx] - SubWeight
-                              : 1;
+      // Don't set the probability of taking the edge from latch to loop header
+      // to less than 1, as this could significantly reduce the loop's hotness,
+      // which would be incorrect in the case of underestimating the trip count.
----------------
aleks-tmb wrote:

Updated, thanks!

https://github.com/llvm/llvm-project/pull/70094


More information about the llvm-commits mailing list