[llvm] [XCOFF] make related SD symbols as isFunction (PR #69553)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 31 01:14:08 PDT 2023


================
@@ -92,10 +92,11 @@ class SymbolizableObjectFile : public SymbolizableModule {
         return Addr < RHS.Addr;
 
       if (Type != None) {
-        // This is a XCOFF symbol. For XCOFF, XTY_SD symbol and its first XTY_LD
-        // symbol have same addresses, the symbol size of XTY_SD symbol is the
-        // size of the section while symbol size of the XTY_LD symbol is 0, but
-        // we need the XTY_LD symbol instead of the XTY_SD symbol.
+        // This is an XCOFF symbol. For XCOFF, an XTY_SD symbol and its first
+        // XTY_LD symbol must have the same addresses. The symbol size of the
----------------
jh7370 wrote:

```suggestion
        // XTY_LD symbol must have the same address. The symbol size of the
```

https://github.com/llvm/llvm-project/pull/69553


More information about the llvm-commits mailing list