[llvm] [LLVM][DWARF] Add support for monolithic types in .debug_names (PR #70515)
David Blaikie via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 30 13:58:00 PDT 2023
================
@@ -305,14 +305,16 @@ void Loc::MMI::addFrameIndexExpr(const DIExpression *Expr, int FI) {
static AccelTableKind computeAccelTableKind(unsigned DwarfVersion,
bool GenerateTypeUnits,
+ bool HasSplitDwarf,
DebuggerKind Tuning,
const Triple &TT) {
// Honor an explicit request.
if (AccelTables != AccelTableKind::Default)
return AccelTables;
// Accelerator tables with type units are currently not supported.
- if (GenerateTypeUnits)
+ if (GenerateTypeUnits &&
+ (DwarfVersion < 5 || HasSplitDwarf || !TT.isOSBinFormatELF()))
----------------
dwblaikie wrote:
Comment probably needs updating - and I'm not sure I understand why these three conditions are the right ones - so maybe the comment will help me understand better what's being added/handled here.
https://github.com/llvm/llvm-project/pull/70515
More information about the llvm-commits
mailing list