[compiler-rt] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

Snehasish Kumar via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 30 13:50:06 PDT 2023


================
@@ -309,7 +323,8 @@ lprofWriteDataImpl(ProfDataWriter *Writer, const __llvm_profile_data *DataBegin,
     return -1;
 
   /* Write the binary id lengths and data. */
-  if (__llvm_write_binary_ids(Writer) == -1)
+  int binary_id_size = __llvm_write_binary_ids(Writer);
----------------
snehasish wrote:

Any reason why we need this change? I don't see a use of binary_id_size apart from this check.

https://github.com/llvm/llvm-project/pull/66825


More information about the llvm-commits mailing list