[lld] [LLD] Tombstone LocalTU entry in .debug_names (PR #70701)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 30 13:19:57 PDT 2023


================
@@ -918,7 +917,8 @@ void InputSection::relocateNonAlloc(uint8_t *buf, ArrayRef<RelTy> rels) {
       continue;
 
     if (tombstone ||
-        (isDebug && (type == target.symbolicRel || expr == R_DTPREL))) {
+        ((isDebug && (type == target.symbolicRel || expr == R_DTPREL))) ||
----------------
dwblaikie wrote:

Would be nice to know from @MaskRay (or anyone else) why this `type == target.symbolicRel` is here, and if there's some way we can generalize it to cover the `.debug_names` case we're interested in (a `R_X86_64_32` relocation) without needing to special case `isDebugNames` in this condition

https://github.com/llvm/llvm-project/pull/70701


More information about the llvm-commits mailing list