[llvm] [test] Align behavior of interrupts.test on different platforms (PR #68556)

Serge Pavlov via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 30 06:56:43 PDT 2023


================
@@ -34,8 +35,8 @@ def run_wrapper():
                                 startupinfo=startupinfo,
                                 creationflags=subprocess.CREATE_NEW_CONSOLE)
     else:
-        proc = subprocess.Popen(args,
-                                stderr=subprocess.PIPE)
+        proc = subprocess.Popen(args, stderr=sys.stderr)
+        proc.wait()
----------------
spavloff wrote:

> Are you sure `wait` is the right thing you want? Could we simplify both this and the line a couple of lines above to `subprocess.run`?

Yes, we can use `subprocess.run`, the PR changed accordingly.

https://github.com/llvm/llvm-project/pull/68556


More information about the llvm-commits mailing list