[llvm] [llvm][AArch64][Assembly]: Add SME_F8F16 and SME_F8F32 Ass/Disass. (PR #70640)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 30 04:10:54 PDT 2023
================
@@ -4546,18 +4548,21 @@ ParseStatus AArch64AsmParser::tryParseZTOperand(OperandVector &Operands) {
if (getParser().parseExpression(ImmVal))
return ParseStatus::NoMatch;
const MCConstantExpr *MCE = dyn_cast<MCConstantExpr>(ImmVal);
+ Operands.push_back(AArch64Operand::CreateImm(
+ MCConstantExpr::create(MCE->getValue(), getContext()), StartLoc,
+ getLoc(), getContext()));
if (!MCE)
----------------
CarolineConcatto wrote:
I think we should change the order :
```
if (!MCE)
return TokError("immediate value expected for vector index");
Operands.push_back(AArch64Operand::CreateImm(
MCConstantExpr::create(MCE->getValue(), getContext()), StartLoc,
getLoc(), getContext()));
```
Just because it is only acceptable to get the value (MCE->getValue()) and push to the operand if we could actually create the constant.
https://github.com/llvm/llvm-project/pull/70640
More information about the llvm-commits
mailing list