[llvm] [JITLink][AArch32] Unittest for error paths of readAddend functionality (PR #69636)

Stefan Gränitz via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 20 12:46:53 PDT 2023


https://github.com/weliveindetail commented:

Nice! Testing error paths sounds like a good addition and it might be something to consider even in a broader scope.

The current implementation looks quite generic though. It's hard to see what is the actual error messages we expect. Maybe we can improve that with matchers. Please see my inline comment for an example. It might even allow to reduce most of the `createXYError()` boilderplate.

What do you think?

https://github.com/llvm/llvm-project/pull/69636


More information about the llvm-commits mailing list