[llvm] [DevPolicy] Add guidance to not submit code or reviews on someone else's (PR #69701)

David Spickett via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 20 03:36:31 PDT 2023


================
@@ -104,6 +104,12 @@ When submitting patches, please do not add confidentiality or non-disclosure
 notices to the patches themselves.  These notices conflict with the LLVM
 licensing terms and may result in your contribution being excluded.
 
+When being asked by someone to add code (e.g. create a PR), or write review
+comments on their behalf, do suggest that they do it directly themselves. Or
+ask the reasons why they're not doing it themselves. There should be few
+legitimate reasons for them not doing so themselves.
+
----------------
DavidSpickett wrote:

I'm struggling to find a way to phrase it, but I think we could do with a statement about the level of due diligence that the person doing the action on behalf of has to do. As there are plausible excuses that could be given by a banned person.

I think adding the statement about the CoC team would help here. So that this is a process that has clear steps. Ask, verify as you can, forward anything untoward to the CoC team.

I wouldn't want people (including me) to read this and draw the conclusion that it's not worth the risk to merge anything on behalf of. Especially as it could lead to a situation where these merges are more and more done by people who are not going to be as attentive.

Not intending this to be some kind of immunity statement, I am ok with merging anyone else's code having some level of risk to it.

https://github.com/llvm/llvm-project/pull/69701


More information about the llvm-commits mailing list