[llvm] [DevPolicy] Add guidance to not submit code or reviews on someone else's (PR #69701)

Kristof Beyls via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 20 02:48:11 PDT 2023


https://github.com/kbeyls created https://github.com/llvm/llvm-project/pull/69701

... behalf.

There should be few legitimate reasons for people not submitting code or review comments themselves. Furthermore, it helps avoid situations where banned individuals circumvent their ban by asking others to submit code or review comments on their behalf.

More details, see
https://discourse.llvm.org/t/submitting-code-or-review-comments-on-someone-elses-behalf/74269

>From cfd222df732c8e3e847e5c71554d4c69ab377b49 Mon Sep 17 00:00:00 2001
From: Kristof Beyls <kristof.beyls at llvm.org>
Date: Mon, 9 Oct 2023 18:18:28 +0100
Subject: [PATCH] [DevPolicy] Add guidance to not submit code or reviews on
 someone else's

... behalf.

There should be few legitimate reasons for people not submitting code or
review comments themselves. Furthermore, it helps avoid situations where
banned individuals circumvent their ban by asking others to submit code
or review comments on their behalf.

More details, see
https://discourse.llvm.org/t/submitting-code-or-review-comments-on-someone-elses-behalf/74269
---
 llvm/docs/DeveloperPolicy.rst | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst
index f9ac746d006a546..acfedcd44b869a6 100644
--- a/llvm/docs/DeveloperPolicy.rst
+++ b/llvm/docs/DeveloperPolicy.rst
@@ -104,6 +104,12 @@ When submitting patches, please do not add confidentiality or non-disclosure
 notices to the patches themselves.  These notices conflict with the LLVM
 licensing terms and may result in your contribution being excluded.
 
+When being asked by someone to add code (e.g. create a PR), or write review
+comments on their behalf, do suggest that they do it directly themselves. Or
+ask the reasons why they're not doing it themselves. There should be few
+legitimate reasons for them not doing so themselves.
+
+
 .. _code review:
 
 Code Reviews



More information about the llvm-commits mailing list