[llvm] [IR] Fix nested constant to instruction conversion (PR #69682)

[Nikita Popov via llvm-commits]

================
@@ -85,9 +90,11 @@ bool convertUsersOfConstantsToInstructions(ArrayRef<Constant *> Consts) {
       if (auto *C = dyn_cast<Constant>(U.get())) {
         if (ExpandableUsers.contains(C)) {
           Changed = true;
-          Instruction *NI = expandUser(BI, C);
-          InstructionWorklist.insert(NI);
-          U.set(NI);
+          auto NewInsts = expandUser(BI, C);
+          for (auto *NI : NewInsts)
+            NI->setDebugLoc(BI->getDebugLoc());
----------------
nikic wrote:

For phi nodes this will take the debug loc from the terminator of the incoming block rather than the phi node -- is that intended?

https://github.com/llvm/llvm-project/pull/69682