[llvm] [AMDGPU][NFCI] Decouple actual register encodings from HWEncoding values. (PR #69452)

Stanislav Mekhanoshin via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 19 03:10:18 PDT 2023


================
@@ -38,9 +38,16 @@ using namespace llvm;
 
 #define DEBUG_TYPE "amdgpu-disassembler"
 
-#define SGPR_MAX                                                               \
-  (isGFX10Plus() ? AMDGPU::EncValues::SGPR_MAX_GFX10                           \
-                 : AMDGPU::EncValues::SGPR_MAX_SI)
+enum : unsigned {
----------------
rampitec wrote:

I do not have strong preference here, but why don't we start with replacing uses of literals with symbolic names in the encoder and see what are we really using?

https://github.com/llvm/llvm-project/pull/69452


More information about the llvm-commits mailing list