[llvm] [AMDGPU][NFCI] Decouple actual register encodings from HWEncoding values. (PR #69452)

Ivan Kosarev via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 19 02:42:36 PDT 2023


================
@@ -38,9 +38,16 @@ using namespace llvm;
 
 #define DEBUG_TYPE "amdgpu-disassembler"
 
-#define SGPR_MAX                                                               \
-  (isGFX10Plus() ? AMDGPU::EncValues::SGPR_MAX_GFX10                           \
-                 : AMDGPU::EncValues::SGPR_MAX_SI)
+enum : unsigned {
----------------
kosarev wrote:

It seems the encoding side isn't interested in the range boundaries much (which makes sense?). `LITERAL_CONST` could be used there, but currently isn't, so maybe it can wait for when we need it in a wider scope? (I wouldn't mind it either way.)

https://github.com/llvm/llvm-project/pull/69452


More information about the llvm-commits mailing list