[llvm] [XCOFF] make related SD symbols as isFunction (PR #69553)

via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 18 19:51:56 PDT 2023


github-actions[bot] wrote:


<!--LLVM CODE FORMAT COMMENT: {clang-format}-->

:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff fd1a0b0ee4d8f6092dad6caff5217b8fd2193798 a88c5ea4c2666ddf38291a32213d0aaf36cde372 -- llvm/include/llvm/DebugInfo/Symbolize/SymbolizableObjectFile.h llvm/include/llvm/Object/XCOFFObjectFile.h llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp llvm/lib/Object/XCOFFObjectFile.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp b/llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp
index 398829b46..c932540f8 100644
--- a/llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp
+++ b/llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp
@@ -16,9 +16,9 @@
 #include "llvm/DebugInfo/DWARF/DWARFContext.h"
 #include "llvm/Object/COFF.h"
 #include "llvm/Object/ELFObjectFile.h"
-#include "llvm/Object/XCOFFObjectFile.h"
 #include "llvm/Object/ObjectFile.h"
 #include "llvm/Object/SymbolSize.h"
+#include "llvm/Object/XCOFFObjectFile.h"
 #include "llvm/Support/Casting.h"
 #include "llvm/Support/DataExtractor.h"
 #include "llvm/TargetParser/Triple.h"
diff --git a/llvm/lib/Object/XCOFFObjectFile.cpp b/llvm/lib/Object/XCOFFObjectFile.cpp
index a090d4c84..3882d5951 100644
--- a/llvm/lib/Object/XCOFFObjectFile.cpp
+++ b/llvm/lib/Object/XCOFFObjectFile.cpp
@@ -1244,7 +1244,7 @@ bool XCOFFSymbolRef::isFunction() const {
 
   // A function definition should not be a common type symbol.
   if (CsectAuxRef.getSymbolType() == XCOFF::XTY_CM)
-     return false;
+    return false;
 
   if (CsectAuxRef.getStorageMappingClass() != XCOFF::XMC_PR)
     return false;

``````````

</details>


https://github.com/llvm/llvm-project/pull/69553


More information about the llvm-commits mailing list