[llvm] [AMDGPU] Remove legalicty checks from imm folding in shrink. NFCI. (PR #69539)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 18 17:16:40 PDT 2023
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-amdgpu
Author: Stanislav Mekhanoshin (rampitec)
<details>
<summary>Changes</summary>
The immediate legality checks are now embedded into the isOperandLegal(). It is not needed to check it again.
---
Full diff: https://github.com/llvm/llvm-project/pull/69539.diff
1 Files Affected:
- (modified) llvm/lib/Target/AMDGPU/SIShrinkInstructions.cpp (+1-2)
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/SIShrinkInstructions.cpp b/llvm/lib/Target/AMDGPU/SIShrinkInstructions.cpp
index 4159dc694c1e037..88c75a0f86a6c13 100644
--- a/llvm/lib/Target/AMDGPU/SIShrinkInstructions.cpp
+++ b/llvm/lib/Target/AMDGPU/SIShrinkInstructions.cpp
@@ -104,8 +104,7 @@ bool SIShrinkInstructions::foldImmediates(MachineInstr &MI,
bool ConstantFolded = false;
if (TII->isOperandLegal(MI, Src0Idx, &MovSrc)) {
- if (MovSrc.isImm() &&
- (isInt<32>(MovSrc.getImm()) || isUInt<32>(MovSrc.getImm()))) {
+ if (MovSrc.isImm()) {
Src0.ChangeToImmediate(MovSrc.getImm());
ConstantFolded = true;
} else if (MovSrc.isFI()) {
``````````
</details>
https://github.com/llvm/llvm-project/pull/69539
More information about the llvm-commits
mailing list