[PATCH] D149742: [SLP]Improve isGatherShuffledEntry by trying per-register shuffle.

Wed Oct 18 15:03:40 PDT 2023

RKSimon added inline comments.

================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/multi-nodes-to-shuffle.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt -passes=slp-vectorizer -S < %s -mtriple=x86_64-unknown-linux -slp-threshold=-107 | FileCheck %s
+; RUN: opt -passes=slp-vectorizer -S < %s -mtriple=x86_64-unknown-linux -slp-threshold=-115 | FileCheck %s

----------------
Please can you add a AVX2 run to confirm that the shuffles are still being suitably split for legal 256-bit vectors?
```
; RUN: opt -passes=slp-vectorizer -S < %s -mtriple=x86_64-unknown-linux -slp-threshold=-115 | FileCheck % --check-prefix=SSE
; RUN: opt -passes=slp-vectorizer -S < %s -mtriple=x86_64-unknown-linux mattr=+avx2 -slp-threshold=-115 | FileCheck % --check-prefix=AVX
```

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149742/new/

https://reviews.llvm.org/D149742