[PATCH] D33289: [AMDGPU] Fix incorrect register usage tracking in GCNUpwardTracker

Wed Oct 18 05:53:35 PDT 2023

foad added a comment.

In D33289#4654325 <https://reviews.llvm.org/D33289#4654325>, @vpykhtin wrote:

> In D33289#4654324 <https://reviews.llvm.org/D33289#4654324>, @foad wrote:
>
>> In D33289#4654317 <https://reviews.llvm.org/D33289#4654317>, @vpykhtin wrote:
>>
>>> Is anyone working on this at the moment?
>>
>> I'm not working on it but I have been thinking about it. The first problem is how to write regression tests for GCNRegPressure.
>
> I can probably come up with a unit test in the way similar to how we test LiveIntervals and LiveVariables.

I wonder if we can test it more directly by adding an analysis pass like this: https://github.com/GPUOpen-Drivers/llvm-project/commit/042be23e3d98963fb02833511a86f4e26378a04d
and then using something like `opt -passes='print<amdgpu-reg-press>'`.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D33289/new/

https://reviews.llvm.org/D33289