[llvm] [unittest] Add option to allow disabling sharding in unittest (PR #67063)

Petr Hosek via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 17 20:52:33 PDT 2023


================
@@ -118,6 +118,12 @@ def parse_args():
         )
 
     execution_group = parser.add_argument_group("Test Execution")
+    execution_group.add_argument(
+        "--disable-gtest-sharding",
+        dest="disableGTestSharding",
----------------
petrhosek wrote:

This variable name is inconsistent with Python style which uses `snake_case`. I'd suggest calling it simply `gtest_sharding` and have a pair of arguments `--gtest-sharding` and `--no-gtest-sharding` to control whether sharding is enabled or disabled, with default being `True`.

https://github.com/llvm/llvm-project/pull/67063


More information about the llvm-commits mailing list