[PATCH] D153990: [DebugInfo][RemoveDIs] Add prototype storage classes for non-instruction variable debug-info

[Jeremy Morse via Phabricator via llvm-commits]

jmorse marked an inline comment as done.
jmorse added a comment.

Sitrep on the `TrailingDPValues` situation -- we had a chat offline, and this is sort of a leftover from an earlier prototype where all DPValues were in a "shadow" list that existed behind the main instruction-list, and had a total order on them. `TrailingPDValues` was the "end" of that list. The model we've ended up with doesn't have that total order (because collections of DPValues are split between instructions) but we still use `TrailingDPValues` to pretend it is, so there's a bit of extra reshuffling that has to happen.

Long story short, I'm going to shift storage of any DPValues that dangle while we remove/add terminators into LLVMContext, as it's effectively temporary global data that we want to hide from the usual instruction APIs, and it doesn't make sense to allocate it into every  block or function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153990/new/

https://reviews.llvm.org/D153990