[PATCH] D149742: [SLP]Improve isGatherShuffledEntry by trying per-register shuffle.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:9510
+  assert(NumParts > 0 && NumParts < VL.size() &&
+         "Expectedpoistive number of registers.");
+  Entries.clear();
----------------
Expected positive 


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:9518
+         "Expected only single user of the gather node.");
+  unsigned SliceSize = VL.size() / NumParts;
+  SmallVector<std::optional<TTI::ShuffleKind>> Res;
----------------
assert(VL.size() % NumParts == 0)?


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:10334
     reorderScalars(GatheredScalars, ReorderMask);
-  auto FindReusedSplat = [&](SmallVectorImpl<int> &Mask) {
+  auto FindReusedSplat = [&](MutableArrayRef<int> Mask) {
     if (!isSplat(E->Scalars) || none_of(E->Scalars, [](Value *V) {
----------------
Pull these kind of NFC cleanups out of the patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149742/new/

https://reviews.llvm.org/D149742