[PATCH] D153777: [ADT][DebugInfo][RemoveDIs] Permit extra flags in ilist_iterator's for communicating debug-info facts

[Jeremy Morse via Phabricator via llvm-commits]

jmorse marked an inline comment as done.
jmorse added a comment.

@dyung has set up a buildbot for this (thanks Doug!), landing shortly.



================
Comment at: llvm/include/llvm/IR/SymbolTableListTraits.h:114-117
+template <class T, typename... Args>
+class SymbolTableList : public iplist_impl<simple_ilist<T, Args...>,
+                                           SymbolTableListTraits<T, Args...>> {
+};
----------------
Orlando wrote:
> has this been clang-formatted?
It has!


================
Comment at: llvm/lib/IR/BasicBlock.cpp:229
   BasicBlock::const_iterator It = I->getIterator();
+  It.setHeadBit(true);
   return It;
----------------
Orlando wrote:
> Worth copying the comment you added to `getFirstInsertionPt` here too?
So done.


================
Comment at: llvm/unittests/ADT/IListIteratorBitsTest.cpp:99-100
+
+  // Test that a node that did not have the iterator bits option given to it
+  // does not get the "with bits" iterator type.
+}
----------------
Orlando wrote:
> Comment floated here from elsewhere?
It's a description of the tests that are below; I think I wrote out the comment to outline what I wanted to test for, then repeated the comments below... I'll just delete it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153777/new/

https://reviews.llvm.org/D153777