[PATCH] D94984: [AIX] simplify xcoff part of function TargetMachine::shouldAssumeDSOLocal()

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 16 11:58:34 PDT 2023


DiggerLin abandoned this revision.
DiggerLin added a comment.
Herald added a project: All.

since the commit did the same change , I closed the patch

commit c5ee3123685ca5d555f80ed6e1bb8eeefca3dfbf <https://reviews.llvm.org/rGc5ee3123685ca5d555f80ed6e1bb8eeefca3dfbf>
Author: Fangrui Song <i at maskray.me>
Date:   Sat Aug 21 12:37:29 2021 -0700

  [TargetMachine] Simplify shouldAssumeDSOLocal. NFC



================
Comment at: llvm/lib/Target/TargetMachine.cpp:153
+  assert(TT.isOSBinFormatELF() || TT.isOSBinFormatWasm() || TT.isOSBinFormatXCOFF());
   assert(RM != Reloc::DynamicNoPIC);
   return false;
----------------
hubert.reinterpretcast wrote:
> I think this looks right, but I'm not sure an extra assert is entirely "NFC".
thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94984/new/

https://reviews.llvm.org/D94984



More information about the llvm-commits mailing list