[lld] [lld] Sort code section chunks by range types on Arm64EC targets. (PR #69099)
Martin Storsjö via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 16 05:06:22 PDT 2023
================
@@ -1403,11 +1420,7 @@ void Writer::assignAddresses() {
// If /FUNCTIONPADMIN is used, functions are padded in order to create a
// hotpatchable image.
- const bool isCodeSection =
- (sec->header.Characteristics & IMAGE_SCN_CNT_CODE) &&
- (sec->header.Characteristics & IMAGE_SCN_MEM_READ) &&
- (sec->header.Characteristics & IMAGE_SCN_MEM_EXECUTE);
- uint32_t padding = isCodeSection ? config->functionPadMin : 0;
+ uint32_t padding = sec->isCodeSection() ? config->functionPadMin : 0;
----------------
mstorsjo wrote:
Yes, with the current github review flow used here, that needs to be a separate PR.
https://github.com/llvm/llvm-project/pull/69099
More information about the llvm-commits
mailing list