[llvm] [CodeGen] Remove LiveVariables::{isPHIJoin, setPHIJoin} (PR #69128)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 15 14:01:38 PDT 2023


kazutakahirata wrote:

> ⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️
> 
> You can test this locally with the following command:
> ```shell
> git-clang-format --diff ea4cc2007efeaf14b8a07b967cb0c570e5b59d7c 4a7029a16b85909e9789832beb55f3da321f6e3a -- llvm/include/llvm/CodeGen/LiveVariables.h llvm/lib/CodeGen/LiveVariables.cpp llvm/lib/CodeGen/PHIElimination.cpp
> ```
> 
> View the diff from clang-format here.
> ```diff
> diff --git a/llvm/include/llvm/CodeGen/LiveVariables.h b/llvm/include/llvm/CodeGen/LiveVariables.h
> index 9ed4c7bdf..38c73390d 100644
> --- a/llvm/include/llvm/CodeGen/LiveVariables.h
> +++ b/llvm/include/llvm/CodeGen/LiveVariables.h
> @@ -293,8 +293,7 @@ public:
>                     MachineBasicBlock *DomBB,
>                     MachineBasicBlock *SuccBB);
>  
> -  void addNewBlock(MachineBasicBlock *BB,
> -                   MachineBasicBlock *DomBB,
> +  void addNewBlock(MachineBasicBlock *BB, MachineBasicBlock *DomBB,
>                     MachineBasicBlock *SuccBB,
>                     std::vector<SparseBitVector<>> &LiveInSets);
>  };
> ```

I'm a bit reluctant to follow the clang-format suggestion because the suggestion is just outside the code I am touching.

https://github.com/llvm/llvm-project/pull/69128


More information about the llvm-commits mailing list