[PATCH] D156716: [AArch64][PAC] Check authenticated LR value during tail call
Momchil Velikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Oct 14 05:01:06 PDT 2023
chill added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64PointerAuth.cpp:256
+
+ // FIXME If FEAT_FPAC is implemented by the CPU, this check can be skipped.
+
----------------
nit: The check for `FEAT_FPAC` perhaps can be done in `getAuthenticatedLRCheckMethod` (and possibly return `None`), so the logic of deciding whether to emit code or not is kept in one place.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156716/new/
https://reviews.llvm.org/D156716
More information about the llvm-commits
mailing list