[llvm] [AMDGPU] Fix comments about afn and arcp in fast unsafe fdiv handling (PR #68982)
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 13 05:16:31 PDT 2023
https://github.com/jayfoad created https://github.com/llvm/llvm-project/pull/68982
None
>From 238250dcbc021d0e9d0a7e1e711ec7f3b91231a6 Mon Sep 17 00:00:00 2001
From: Jay Foad <jay.foad at amd.com>
Date: Fri, 13 Oct 2023 13:14:29 +0100
Subject: [PATCH] [AMDGPU] Fix comments about afn and arcp in fast unsafe fdiv
handling
---
llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp | 4 ++--
llvm/lib/Target/AMDGPU/SIISelLowering.cpp | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
index 4797e5a7a61d4cf..02cb77f6ecaca4e 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
@@ -4641,8 +4641,8 @@ bool AMDGPULegalizerInfo::legalizeFastUnsafeFDIV(MachineInstr &MI,
}
}
- // For f16 require arcp only.
- // For f32 require afn+arcp.
+ // For f16 require afn or arcp.
+ // For f32 require afn.
if (!AllowInaccurateRcp && (ResTy != LLT::scalar(16) ||
!MI.getFlag(MachineInstr::FmArcp)))
return false;
diff --git a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
index 9bd0f5390b19e31..33f65ab786584fd 100644
--- a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
+++ b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
@@ -9577,8 +9577,8 @@ SDValue SITargetLowering::lowerFastUnsafeFDIV(SDValue Op,
}
}
- // For f16 require arcp only.
- // For f32 require afn+arcp.
+ // For f16 require afn or arcp.
+ // For f32 require afn.
if (!AllowInaccurateRcp && (VT != MVT::f16 || !Flags.hasAllowReciprocal()))
return SDValue();
More information about the llvm-commits
mailing list